Review Request 123923: Reuse the existing Notify method for Notification's DataEngine createNotification call

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123923/
-----------------------------------------------------------

(Updated May 28, 2015, 3:33 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit a12bb76502952749c069b9ab70ac61ee1353079b by Martin Klapetek to branch Plasma/5.3.


Repository: plasma-workspace


Description
-------

This puts the notifications coming from the Jobs applet through the same routines as normal notifications, including proper parsing and escaping and stuff.

This also fixes bug 342605


Diffs
-----

  applets/notifications/package/contents/ui/Jobs.qml 3307d38 
  applets/notifications/package/contents/ui/Notifications.qml 333f5b8 
  dataengines/notifications/notificationaction.cpp db27cb3 
  dataengines/notifications/notifications.operations 93b7f0c 
  dataengines/notifications/notificationsengine.h d8507d0 
  dataengines/notifications/notificationsengine.cpp 37a11dd 

Diff: https://git.reviewboard.kde.org/r/123923/diff/


Testing
-------

Copy files, notification appears correctly, is closed correctly and everything works as expected.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150528/b2e8b997/attachment.html>