Review Request 123884: Make sure the desktop folderview doesn't overlap with panels.

[Eike Hein]

> On May 24, 2015, 8:12 p.m., Eike Hein wrote:
> > Please adapt this to match up with http://quickgit.kde.org/?p=plasma-desktop.git&a=blob&h=e15933a3d6310cf053d299d32a9c0179d1332074&hb=bc4656c9f0405afd1eb0a09ced32d1f2b44f0b52&f=containments%2Ffolder%2Fpackage%2Fcontents%2Fui%2Fmain.qml#l61, in particular see http://quickgit.kde.org/?p=plasma-desktop.git&a=commit&h=27afc666c7adbc8bf8b0c4ffa7105ecad9ffd27f
> 
> Eike Hein wrote:
>     ^ That means adding this to the DropArea in main.qml as before btw, the desktop containment used to have it as well (minus the overflow special case).
> 
> Yoann Laissus wrote:
>     Updated !
>     Do you think we need to use the same overflow mechanism for the right margin ?

Actually yes, but depending on the rows vs. columns setting since it changes the scroll overflow axis (in columns mode the scrollbar appears horizontally).


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123884/#review80784
-----------------------------------------------------------


On May 27, 2015, 7:47 p.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123884/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 7:47 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Currently, when the desktop is configured with "Folder view" mode, it uses the whole screen, no matter if there are panels in the area.
> This patch resizes the folder view to the available space to avoid overlaps with panels.
> 
> 
> Diffs
> -----
> 
>   containments/desktop/package/contents/ui/FolderViewLayer.qml 19495b4df4afec18bc90de60ba11eb60b90c52a5 
>   containments/desktop/package/contents/ui/main.qml c546236abf6376963180ffec648d412bcd6e40db 
> 
> Diff: https://git.reviewboard.kde.org/r/123884/diff/
> 
> 
> Testing
> -------
> 
> Tested with panels on each screen side
> 
> 
> File Attachments
> ----------------
> 
> Without the patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/0572c44b-1f06-46ab-86ad-9aa626c0dc2b__with_overlap.jpg
> With the patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8e137ad4-6a6d-4a9c-b9b9-3b9bd7bf05ec__without_overlap.jpg
> 
> 
> Thanks,
> 
> Yoann Laissus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150527/6f842c09/attachment.html>