Review Request 123671: add visibleWhileDesktopShown property
Thomas Lübking
thomas.luebking at gmail.com
Tue May 26 21:03:18 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123671/
-----------------------------------------------------------
(Updated Mai 26, 2015, 9:03 nachm.)
Status
------
This change has been discarded.
Review request for Plasma and Marco Martin.
Bugs: 346837, 346933 and 347212
http://bugs.kde.org/show_bug.cgi?id=346837
http://bugs.kde.org/show_bug.cgi?id=346933
http://bugs.kde.org/show_bug.cgi?id=347212
Repository: plasma-framework
Description
-------
plasmoids only need to add
Plasmoid.visibleWhileDesktopShown: true;
to ensure their panel (and thus them) remains visible while showing the desktop
This is achieved by setting the panel transient for the (first found, under them and visible) desktop type window.
This is mostly relevant for the showdesktop plasmoid (for now)
Notice that all bugs are only CC, we need this to be used in the showdesktop plasmoid.
Diffs
-----
src/plasmaquick/appletquickitem.h dffbcf3
src/plasmaquick/appletquickitem.cpp 0748a8d
src/plasmaquick/private/appletquickitem_p.h a1ec683
Diff: https://git.reviewboard.kde.org/r/123671/diff/
Testing
-------
added/removed (multiple) showdesktop plasmoids - panel transient for correct desktop window (and visible) unless the last is gone (they seem to be deleted with a short random delay?)
Thanks,
Thomas Lübking
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150526/73f42d95/attachment.html>
More information about the Plasma-devel
mailing list