Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled

[Martin Klapetek]

> On April 16, 2015, 1:43 p.m., Kai Uwe Broulik wrote:
> > I think we should always pulse, and if available, use the needs attention icon (but don't cycle between normal and attention icon)
> 
> Martin Klapetek wrote:
>     If you don't cycle it's quite easy to miss, so I think there'd be very little point in just switching the icon (the purpose is to get your attention).
> 
> Martin Klapetek wrote:
>     Ah I misunderstood. The slight problem I see with always using the attention icon for the pulse animation is that they are not necessarily covered by the plasma theme, so when it starts pulsing with attention icon, the icon can look completely different while simply pulsing the normal icon seems more consistent. Dunno.
> 
> Martin Klapetek wrote:
>     So uhh....any comments?

Last call for comments, then I'm going to push this. I think that a month and 10 days is enough time :P


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123381/#review79045
-----------------------------------------------------------


On April 16, 2015, 1:23 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123381/
> -----------------------------------------------------------
> 
> (Updated April 16, 2015, 1:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This returns the kde4 behavior of simply switching the icon for attention icon when animations are disabled.
> 
> I don't think that always using the attention icon with the pulse animation looks good, it looks like there's too much going on. I believe it should be an either-or. So I did it only as a fallback.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/ui/StatusNotifierItem.qml 5380b09 
>   applets/systemtray/package/contents/ui/TaskDelegate.qml f2738bd 
> 
> Diff: https://git.reviewboard.kde.org/r/123381/diff/
> 
> 
> Testing
> -------
> 
> I didn't test with animations off (I'm not sure how to set) so I just explicitly enabled the timer and disabled the PulseAnimation. Works just like in the old times.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150526/4d2e5612/attachment.html>