Review Request 123884: Make sure the desktop folderview doesn't overlap with panels.

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123884/#review80752
-----------------------------------------------------------



containments/desktop/package/contents/ui/main.qml (lines 238 - 241)
<https://git.reviewboard.kde.org/r/123884/#comment55365>

    Can't you just use bindings for that?
    
    anchors {
        leftMargin: plasmoid.availableScreenRect.x
        …
    }



containments/desktop/package/contents/ui/main.qml (line 239)
<https://git.reviewboard.kde.org/r/123884/#comment55366>

    That doesn't look right, I think you need to subract the x value as well


- Kai Uwe Broulik


On Mai 23, 2015, 5:14 nachm., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123884/
> -----------------------------------------------------------
> 
> (Updated Mai 23, 2015, 5:14 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Currently, when the desktop is configured with "Folder view" mode, it uses the whole screen, no matter if there are panels in the area.
> This patch resizes the folder view to the available space to avoid overlaps with panels.
> 
> 
> Diffs
> -----
> 
>   containments/desktop/package/contents/ui/main.qml c546236abf6376963180ffec648d412bcd6e40db 
> 
> Diff: https://git.reviewboard.kde.org/r/123884/diff/
> 
> 
> Testing
> -------
> 
> Tested with panels on each screen side
> 
> 
> File Attachments
> ----------------
> 
> Without the patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/0572c44b-1f06-46ab-86ad-9aa626c0dc2b__with_overlap.jpg
> With the patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8e137ad4-6a6d-4a9c-b9b9-3b9bd7bf05ec__without_overlap.jpg
> 
> 
> Thanks,
> 
> Yoann Laissus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150523/3017352c/attachment.html>