Review Request 123682: Plasma-Desktop: Port kcm fonts to QML.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123682/#review80730
-----------------------------------------------------------


Yeah, I think it's nearly OK to merge into that branch.


File Attachment: fonts qml port - fonts_qml2.png
<https://git.reviewboard.kde.org//r/123682/#fcomment404>

    Can we make this a component in KQuickControls would be useful for a few applets. (thinking of Kai's last patch to digital clock)



kcms/fonts/package/contents/ui/main.qml (line 27)
<https://git.reviewboard.kde.org/r/123682/#comment55350>

    not used



kcms/fonts/package/contents/ui/main.qml (lines 277 - 279)
<https://git.reviewboard.kde.org/r/123682/#comment55351>

    Any idea why?


- David Edmundson


On May 19, 2015, 2:47 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123682/
> -----------------------------------------------------------
> 
> (Updated May 19, 2015, 2:47 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This patch ports the kcm fonts to QML.
> 
> 
> Diffs
> -----
> 
>   kcms/fonts/CMakeLists.txt d73636e 
>   kcms/fonts/fonts.cpp 74da799 
>   kcms/fonts/fonts.desktop 5b486ed 
>   kcms/fonts/fonts.h d98bbe2 
>   kcms/fonts/kcm_fonts.desktop PRE-CREATION 
>   kcms/fonts/package/contents/ui/main.qml PRE-CREATION 
>   kcms/fonts/package/metadata.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123682/diff/
> 
> 
> Testing
> -------
> 
> Everything works execpt from the ComboBox and the FontDialog ("Configure Font").
> 
> * FontDialog
> 
> If you open the kcm inside from the system settings, everything is ok.
> 
> If you use kcmshell5 fonts, the FontDialog is opening behing the kcm window.
> In order to solve this issue we must use the setTransientParent, but how can
> i do that in the FontDialog?
> 
> * ComboBox
> 
> If you open the kcm with the "kcmshell5 fonts", the dropdown menu renders fine.
> 
> But if you open it inside from the system settings, the dropdown menu, renders
> in the left of the ComboBox.
> 
> 
> Also these two signals (main.qml line 295)
> 
> onDpiChanged 
> onAliasingChanged 
> 
> are being emitted but the kcm.needsSave doesn't work...
> 
> 
> File Attachments
> ----------------
> 
> fonts qml port
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/19/467d70b7-69c8-4ad1-8da5-db0e9320bc03__fonts_qml2.png
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150522/dd4c8661/attachment.html>