Review Request 123877: [digital-clock] Bring back font family and color options

[Andrew Lake]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123877/#review80719
-----------------------------------------------------------


Just a couple observations:
1. I think it might be helpful to have a way to restore using the default font specified in the fonts kcm without having to explicitly know/set the font to match the default. A checkbox to enable/disable setting a custom font family as is done for the color might work.
2. "Font style" in the fonts kcm refers to face within a font family like weight (light, normal, bold, heavy) and emphasis (italic, oblique). So I think the label here should be "Font" not "Font style" for consistency.

Hope this helps!

- Andrew Lake


On May 21, 2015, 9:45 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123877/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 9:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 348072
>     https://bugs.kde.org/show_bug.cgi?id=348072
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This restores the custom font family and font color options; also clean ups the layout a bit - we don't have a FormLayout, so that's the best it can get. Did I mention dealing with ComboBox is horrible?
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/config/main.xml 5237160 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc 
> 
> Diff: https://git.reviewboard.kde.org/r/123877/diff/
> 
> 
> Testing
> -------
> 
> Checking and unchecking the custom color checkbox properly sets/unsets the color, the "Default" font option restores the default font, options in the dialog are properly restored when it opens, Apply button does not appear to have become broken.
> 
> 
> File Attachments
> ----------------
> 
> The clock
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png
> Settings
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150522/9b983c11/attachment.html>