Review Request 123870: check all shell directories

Aleix Pol Gonzalez aleixpol at kde.org
Thu May 21 15:11:15 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123870/#review80696
-----------------------------------------------------------


+1


shell/shellmanager.cpp (line 115)
<https://git.reviewboard.kde.org/r/123870/#comment55329>

    This screams for a separate function ;)


- Aleix Pol Gonzalez


On May 21, 2015, 3:22 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123870/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 3:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> BUG: 348056
> 
> 
> Diffs
> -----
> 
>   shell/shellmanager.cpp 6f89dd4f8e110f1e5aa0de021840b08f2c4363b6 
> 
> Diff: https://git.reviewboard.kde.org/r/123870/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150521/03e2eb6c/attachment.html>


More information about the Plasma-devel mailing list