Review Request 123735: version of QmlObject with a static engine

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/#review80695
-----------------------------------------------------------

Ship it!


Awesome. I love the test!


autotests/quickviewsharedengine.cpp (line 189)
<https://git.reviewboard.kde.org/r/123735/#comment55325>

    Very minor thing -
    
    QCOMPARE(view->status(), QQcmlComponent::Error);
    QCOMPARE(view->errors().count(), 1);



src/kdeclarative/qmlobjectsharedengine.cpp (line 48)
<https://git.reviewboard.kde.org/r/123735/#comment55326>

    Could you please add a comment specifying why 2 refs is the magic number.
    
    I understand that it's our own engineRef and s_engine, but it took me a bit to figure it out.
    
    How about -
    // Delete when we along with the static shared pointer are the only references to it.


- Vishesh Handa


On May 21, 2015, 10:52 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123735/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 10:52 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> to make easier doing applications like plasma that use a lot of qml to have a single engine make a subclass of QmlObject called QmlObjectSharedEngine that has a single, static QQmlEngine
> 
> Adds a class called QuickViewSharedEngine that has the same behavior as QmlObjectSharedEngine(using it): static QQmlEngine, separed rootContexts() for each instance.
> This is used by desktopviews and panelviews to share their engine.
> 
> Unfortunately it may not be possible to get the applet configuration dialogs to use this, since they still need a separed engine in order to have a different controls style (qstyle based) than the stuff in the desktop/panel
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt adc1102 
>   autotests/quickviewsharedengine.cpp PRE-CREATION 
>   autotests/util.h PRE-CREATION 
>   autotests/util.cpp PRE-CREATION 
>   src/kdeclarative/CMakeLists.txt d73bff0 
>   src/kdeclarative/kdeclarative.cpp b3906e2 
>   src/kdeclarative/qmlobject.h f26b67d 
>   src/kdeclarative/qmlobject.cpp c483665 
>   src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION 
>   src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION 
>   src/quickaddons/CMakeLists.txt 777d07c 
>   src/quickaddons/quickviewsharedengine.h PRE-CREATION 
>   src/quickaddons/quickviewsharedengine.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123735/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150521/9106f974/attachment-0001.html>