Review Request 123860: Handle backend being deleted during GetConfigOperation

David Edmundson david at davidedmundson.co.uk
Wed May 20 12:08:11 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123860/
-----------------------------------------------------------

Review request for Plasma and Solid.


Repository: libkscreen


Description
-------

GetConfigOperation stores a raw pointer to the backend in a property of
the QDBusPendingCallWatcher

BackendManager owns this backend and can delete it at will if it becomes
invalidated, leaving a dangling pointer in the watcher's property.

BUG: 347626


Diffs
-----

  src/getconfigoperation.cpp dac7a33edd87adb53d7b773acfe7f7dfe2229394 

Diff: https://git.reviewboard.kde.org/r/123860/diff/


Testing
-------

Never made the crash happen myself, but looking at the backtrace and the code it seems the a way it could have happened.

Tested behaviour as before still works.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150520/3fd3c1df/attachment.html>


More information about the Plasma-devel mailing list