Review Request 123846: Enable translations for devicenotifications dataengine

David Edmundson david at davidedmundson.co.uk
Tue May 19 10:07:55 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123846/#review80617
-----------------------------------------------------------


+1 on the plasma side, for backporting too

- David Edmundson


On May 18, 2015, 11:21 p.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123846/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 11:21 p.m.)
> 
> 
> Review request for Localization and Translation (l10n) and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The patch should be quite straightforward, but see below.
> 
> If correct, can I apply it to Plasma/5.3 as well? Allowing translations of previously untranslatable strings does not break the string freeze.
> 
> 
> Diffs
> -----
> 
>   dataengines/devicenotifications/CMakeLists.txt 0b89b5e 
>   dataengines/devicenotifications/Messages.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123846/diff/
> 
> 
> Testing
> -------
> 
> I could not test it, sorry, but I had to report it before forgetting.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150519/0dc38663/attachment.html>


More information about the Plasma-devel mailing list