Review Request 122648: Make notifications --reverse aware

Martin Klapetek martin.klapetek at gmail.com
Mon May 18 12:54:25 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122648/
-----------------------------------------------------------

(Updated May 18, 2015, 12:54 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 7253c12a2b089176d0354c6a3a88b536befb5653 by Martin Klapetek to branch Plasma/5.3.


Bugs: 343251
    https://bugs.kde.org/show_bug.cgi?id=343251


Repository: plasma-workspace


Description
-------

Now it works with plasmashell --reverse


Diffs
-----

  applets/notifications/package/contents/ui/NotificationItem.qml 86b0b6e 
  applets/notifications/package/contents/ui/NotificationPopup.qml 6902459 
  applets/notifications/package/contents/ui/main.qml 1e5efa3 
  applets/notifications/plugin/notificationshelper.h ca0b63b 
  applets/notifications/plugin/notificationshelper.cpp e7c4e29 

Diff: https://git.reviewboard.kde.org/r/122648/diff/


Testing
-------

Tested both --reverse and not --reverse and both look good. See screenshot.


File Attachments
----------------

--reverse
  https://git.reviewboard.kde.org/media/uploaded/files/2015/02/20/5058fe12-ecdd-4345-bcec-4392bbfa78f5__notifications-reverse.png


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150518/79855c6a/attachment.html>


More information about the Plasma-devel mailing list