Review Request 123836: Ensure KNotification can be used from a non-GUI thread

Martin Klapetek martin.klapetek at gmail.com
Mon May 18 12:13:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123836/
-----------------------------------------------------------

Review request for KDE Frameworks and Plasma.


Repository: knotifications


Description
-------

The NotifyByPopup plugin is accessing QApplication::desktop()
in constructor which Qt does not like when that happens on non-GUI
thread and asserts. So this moves that code only when actually
needed plus it checks first if the code is run in non-GUI thread
and does nothing if it's not.

This is only for the popup fallback notifications, normal notifications
work just fine.


Diffs
-----

  src/notifybypopup.cpp 2f84ab0 

Diff: https://git.reviewboard.kde.org/r/123836/diff/


Testing
-------

Tested with both multi-threaded and single-threaded codes.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150518/73935062/attachment.html>


More information about the Plasma-devel mailing list