Review Request 123821: Highlight leading and trailing whitespace

[Patrick Eigensatz]

> On Mai 16, 2015, 7:39 nachm., Patrick Eigensatz wrote:
> > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 70
> > <https://git.reviewboard.kde.org/r/123821/diff/1/?file=369603#file369603line70>
> >
> >     One question: Does this line only apply to the displayed string? What if you copied e.g. HTML-Tags, modified the clipboard content and then use klipper to get the HTML-Tags again, is the content still correct?
> 
> Kai Uwe Broulik wrote:
>     Don't worry, it's just the visual representation.
>     
>     Previously, the Label used PlainText and showed everything verbatim, however, to allow HTML formatting, I enabled StyledText but now I need to make sure you're not accidentally doing a network request when copying an <img> tag or messing up the layout.

Ah, I see. Great! :)

QStrings provide an HTML escape method:
http://stackoverflow.com/questions/14173161/how-can-i-make-a-qstring-html-escaped

This would escape <img> tags so nothing leaves the computer...


- Patrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123821/#review80482
-----------------------------------------------------------


On Mai 16, 2015, 6:54 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123821/
> -----------------------------------------------------------
> 
> (Updated Mai 16, 2015, 6:54 nachm.)
> 
> 
> Review request for Plasma, KDE Usability, Martin Gräßlin, and Patrick Eigensatz.
> 
> 
> Bugs: 159267
>     https://bugs.kde.org/show_bug.cgi?id=159267
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch makes klipper highlight leading and trailing white-space (line break, spaces, tabs) by coloring them and replacing them with visible characters
> 
> (Using the "open box", "double arrow" and "down-left arrow" that look more familiar (though I recall word processors using a mid dot for space) instead of the unicode SP/HT/CR thingies)
> 
> 
> Diffs
> -----
> 
>   applets/clipboard/contents/ui/ClipboardItemDelegate.qml f9b0d59 
> 
> Diff: https://git.reviewboard.kde.org/r/123821/diff/
> 
> 
> Testing
> -------
> 
> Seems to work pretty well, copied random console output
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/e31d060b-ab13-4f37-9ba3-26cb743ddee4__klippercolorcoded.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150516/85fcca1e/attachment.html>