Review Request 123821: Highlight leading and trailing whitespace

[Patrick Eigensatz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123821/#review80478
-----------------------------------------------------------


This looks awesome! :) Are we still supposed to have a configuration option for this?
In my other review request we've got a bit stuck because of HIG...

- Patrick Eigensatz


On Mai 16, 2015, 6:54 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123821/
> -----------------------------------------------------------
> 
> (Updated Mai 16, 2015, 6:54 nachm.)
> 
> 
> Review request for Plasma, KDE Usability, Martin Gräßlin, and Patrick Eigensatz.
> 
> 
> Bugs: 159267
>     https://bugs.kde.org/show_bug.cgi?id=159267
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch makes klipper highlight leading and trailing white-space (line break, spaces, tabs) by coloring them and replacing them with visible characters
> 
> (Using the "open box", "double arrow" and "down-left arrow" that look more familiar (though I recall word processors using a mid dot for space) instead of the unicode SP/HT/CR thingies)
> 
> 
> Diffs
> -----
> 
>   applets/clipboard/contents/ui/ClipboardItemDelegate.qml f9b0d59 
> 
> Diff: https://git.reviewboard.kde.org/r/123821/diff/
> 
> 
> Testing
> -------
> 
> Seems to work pretty well, copied random console output
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/e31d060b-ab13-4f37-9ba3-26cb743ddee4__klippercolorcoded.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150516/50813711/attachment.html>