Review Request 123818: soliddevice: Use KDiskFreeSpaceInfo instead of solid to get disk size

[Yoann Laissus]

> On mai 16, 2015, 6:03 après-midi, Mark Gaiser wrote:
> > Why the C-Sytle casts? (qulonglong)..
> > If you use casts, use the C++ style casts.

Ah, you're right, several years without c++, it doesn't help ...
I just send a new patch with a refactor of this part.


- Yoann


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123818/#review80471
-----------------------------------------------------------


On mai 16, 2015, 6:44 après-midi, Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123818/
> -----------------------------------------------------------
> 
> (Updated mai 16, 2015, 6:44 après-midi)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Currently, the size of devices is retrieved with solid.
> Unfortunately, it doesn't work for network shares. Only the "StorageVolume" type has the "size" option.
> 
> KDiskFreeSpaceInfo supports every mounted device, not matter its type.
> 
> 
> Diffs
> -----
> 
>   applets/devicenotifier/package/contents/ui/FullRepresentation.qml 0a5b035d1afac368faf85f6dd0ff41bab4812562 
>   dataengines/soliddevice/soliddeviceengine.h 85bdc68d4d7a9a8704d8ff1dcd29355c784ed435 
>   dataengines/soliddevice/soliddeviceengine.cpp 94819c7405a3eb4b0ef679a55de2de20bd05fdb2 
>   dataengines/soliddevice/soliddeviceservice.cpp f2f96ef4d63f41e3e2ea9bf31297adfcdf151a97 
> 
> Diff: https://git.reviewboard.kde.org/r/123818/diff/
> 
> 
> Testing
> -------
> 
> Tested with local disks, USB devices, NFS shares
> 
> 
> Thanks,
> 
> Yoann Laissus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150516/e50c1ee2/attachment-0001.html>