Review Request 123621: Fix reverse scroll setting in Mouse KCM

Hrvoje Senjan hrvoje.senjan at gmail.com
Fri May 15 10:48:14 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123621/#review80387
-----------------------------------------------------------



kcms/input/mouse.cpp (line 79)
<https://git.reviewboard.kde.org/r/123621/#comment55158>

    you're missing check for xf86-input-evdev devel files in cmake (i guess some copying of how's done for synaptics could do)


- Hrvoje Senjan


On May 15, 2015, 6:45 a.m., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123621/
> -----------------------------------------------------------
> 
> (Updated May 15, 2015, 6:45 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> The old swap-button-map method for reverse scroll doesn't work for Qt5, this patch uses XInput2 api to negate "Evdev Scroll Distance" for device with real scroll wheel, and swap "Evdev Wheel Emulation Axes" when device uses emulated scroll wheel, such as Thinkpad Trackpoint.
> 
> 
> Diffs
> -----
> 
>   kcms/input/CMakeLists.txt 6cbe207 
>   kcms/input/mouse.cpp 1450de8 
> 
> Diff: https://git.reviewboard.kde.org/r/123621/diff/
> 
> 
> Testing
> -------
> 
> built on archlinux and tested by replacing kcm_input.so, new kcm works on my machine.
> 
> 
> Thanks,
> 
> Yue Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150515/b1bba550/attachment.html>


More information about the Plasma-devel mailing list