Review Request 123789: automatically add newly installed plasmoids in the systray

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123789/#review80338
-----------------------------------------------------------



applets/systemtray/package/contents/ui/main.qml (line 104)
<https://git.reviewboard.kde.org/r/123789/#comment55122>

    Do
    > var foo = []
    
    instead of
    
    > var foo = new Array()



applets/systemtray/package/contents/ui/main.qml (line 110)
<https://git.reviewboard.kde.org/r/123789/#comment55123>

    Check whether defaults = host.defaultPlasmoids.slice() works and is faster


- Kai Uwe Broulik


On Mai 14, 2015, 11:03 vorm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123789/
> -----------------------------------------------------------
> 
> (Updated Mai 14, 2015, 11:03 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 345872
>     https://bugs.kde.org/show_bug.cgi?id=345872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> if new plasmoids are installed that are systray enabled and enabled by default, automatically add them, unless they were disabled explicitly. This solves a problem distributions seem to add while updating to new plasma releases.
> 
> obtain this by keeping both a list of explicitly enabled stuff and all the already known stuff
> 
> it does horrible things with arrays, that's due to some weird sideeffects of having qstringlists as properties, of which we'll have to pay close attention to
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/config/main.xml 2967dba 
>   applets/systemtray/package/contents/ui/main.qml fd59a14 
> 
> Diff: https://git.reviewboard.kde.org/r/123789/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150514/978f842b/attachment-0001.html>