Review Request 123784: Make sure we're not magically converting from QString to QUrl

Eike Hein hein at kde.org
Thu May 14 00:12:01 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123784/#review80324
-----------------------------------------------------------

Ship it!


Ship It!

- Eike Hein


On May 14, 2015, 12:02 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123784/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 12:02 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Spots a couple of bugs and lets us all rejoice for using a type-safe language (when the correct flags are set).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt bfc97ad 
>   desktop/desktopnotifier.cpp af43f84 
>   filenamesearch/kio_filenamesearch.cpp 7d59b75 
>   mtp/kio_mtp.cpp 6487def 
>   network/ioslave/networkslave.cpp 0e90c3a 
>   network/kded/kioslavenotifier.cpp 77fe22c 
>   sftp/kio_sftp.cpp 8e9ab37 
> 
> Diff: https://git.reviewboard.kde.org/r/123784/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150514/476ba819/attachment.html>


More information about the Plasma-devel mailing list