Review Request 123735: version of QmlObject with a static engine

[Marco Martin]

> On May 12, 2015, 5:45 p.m., Mark Gaiser wrote:
> > src/kdeclarative/qmlobjectsharedengine.h, line 57
> > <https://git.reviewboard.kde.org/r/123735/diff/5/?file=368396#file368396line57>
> >
> >     std::unique_ptr<...> ...
> >     then you can also forget about the delete in the destructor.

buh, fine


> On May 12, 2015, 5:45 p.m., Mark Gaiser wrote:
> > src/kdeclarative/qmlobjectsharedengine.cpp, line 48
> > <https://git.reviewboard.kde.org/r/123735/diff/5/?file=368397#file368397line48>
> >
> >     static const QQmlEngine ...
> >     
> >     Prevents changing the pointer later on.

not at the moment, since it's initialized to 0 and then instantiated only if needed, and refcounted.
it may become const if it would get instantiated no matter what, but don't like it that much


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/#review80252
-----------------------------------------------------------


On May 12, 2015, 4:12 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123735/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 4:12 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> to make easier doing applications like plasma that use a lot of qml to have a single engine make a subclass of QmlObject called QmlObjectSharedEngine that has a single, static QQmlEngine
> 
> 
> Diffs
> -----
> 
>   src/kdeclarative/CMakeLists.txt d73bff0 
>   src/kdeclarative/kdeclarative.cpp b3906e2 
>   src/kdeclarative/qmlobject.h f26b67d 
>   src/kdeclarative/qmlobject.cpp c483665 
>   src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION 
>   src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123735/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150513/384c14f5/attachment-0001.html>