Review Request 123770: Play the login sound in its own thread

David Edmundson david at davidedmundson.co.uk
Wed May 13 14:37:06 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123770/#review80304
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On May 13, 2015, 10:09 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123770/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 10:09 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This feature was reverted back in the days as somehow it was blocking with PulseAudio startup which delayed the startup sequence quite considerably. This moves the sound playing into its own thread, which should prevent the blocking.
> 
> 
> Diffs
> -----
> 
>   ksmserver/startup.cpp 4155347 
> 
> Diff: https://git.reviewboard.kde.org/r/123770/diff/
> 
> 
> Testing
> -------
> 
> I was never able to reproduce the blocking, so I'm not sure if this actually fixes the problem.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150513/a607b87d/attachment.html>


More information about the Plasma-devel mailing list