Review Request 123727: [klipper] Ensure global shortcut actions work

Martin Klapetek martin.klapetek at gmail.com
Tue May 12 08:15:36 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123727/#review80232
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Klapetek


On May 12, 2015, 7:27 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123727/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 7:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 345945
>     https://bugs.kde.org/show_bug.cgi?id=345945
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Some actions were set to not-visible in order to not show them in
> the popup if not in standalone mode. This has the side effect of
> global shortcuts no longer working as global shortcuts do not
> trigger for not visible actions.
> 
> To fullfill both needs the check is now done to only add the actions
> to the popup if it's in standalone mode, but the visibility is not
> changed.
> 
> BUG: 345945
> FIXED-IN: 5.3.1
> 
> 
> Diffs
> -----
> 
>   klipper/klipper.cpp da7d831d1c659f0385966acd98a9d7fbc2ff6c06 
> 
> Diff: https://git.reviewboard.kde.org/r/123727/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150512/2fb3d8ff/attachment.html>


More information about the Plasma-devel mailing list