Review Request 123686: Revert to old show desktop behaviour

[Sebastian Kügler]

> On May 8, 2015, 5:44 p.m., Thomas Lübking wrote:
> > -1
> > 
> > The question is "what", not "how" to do it and as stated in the mailing list, suggesting minmize all when it's not is really the least favorable "how".
> > 
> > 5.3.1 is > 10 days away and even iff we really cannot come to a final decision within the next week, I'll just provide a patch that restores the previous behavior on top of the current implementation (keep panels visible - I have a patch for that anyway - and break the state whenever a window is activated)

That's awesome, thanks Thomas! Let me know how I can help.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123686/#review80097
-----------------------------------------------------------


On May 8, 2015, 3:56 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123686/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 3:56 p.m.)
> 
> 
> Review request for kwin, Plasma and KDE Usability.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> Revert to old show desktop behaviour
> 
> This basically reverts the show desktop feature to the old behaviour.
> Its meant as a temporary measure, since the new show desktop semantics
> reveal a number of bugs and change the behaviour of the feature in a way
> that makes it hard to go back to the original behaviour.
> 
> This feature will need more thinking, so rather bring back the old
> behaviour in -stable to give us some time to hammer out the interaction
> and bugs in the new implementation.
> 
> 
> Diffs
> -----
> 
>   client.h 40d503cfa917b7c116ab1b593c64dfb9f05513e4 
>   client.cpp a6fbf3ea92ca713d6ad15aab30f6415663281ddf 
>   layers.cpp b6d5b75f8f67a7d3f4d325acfe9e6e8c0da2b952 
>   manage.cpp 75af4e519b929007fb3f36fe1ade71b89efb8a6a 
>   workspace.h 4acefb4fc8c64e0abfae4b86222b869de193c6df 
>   workspace.cpp 09ae9a2c113ba8c8ddfd0dd45ae91cdf20a78ba0 
> 
> Diff: https://git.reviewboard.kde.org/r/123686/diff/
> 
> 
> Testing
> -------
> 
> Used show desktop from panel, hot corner, checked if behaviour is consistent with previous behaviour.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150509/ceddf1ed/attachment.html>