Review Request 123673: capability to load QML kcms in plasmoid config windows

[Marco Martin]

> On May 7, 2015, 1:07 p.m., David Edmundson wrote:
> > src/plasmaquick/configmodel.cpp, line 213
> > <https://git.reviewboard.kde.org/r/123673/diff/1/?file=367374#file367374line213>
> >
> >     who owns the KCM?
> >     
> >     this model or the QMLEngine requesting the KCM?
> >     
> >     if it's the QML, we're potentially returning dangling pointers here as it might have been deleted.
> >     
> >     if it's the C++ we're leaking them.

the kcm instance should be owned by the model, and exist until the model does (closing the config window all gets deleted)

hmm, what i see is that the kcm instance doesn't have a parent, should fix that.


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123673/#review80041
-----------------------------------------------------------


On May 7, 2015, 12:41 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123673/
> -----------------------------------------------------------
> 
> (Updated May 7, 2015, 12:41 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> With the same mechanism as plasma 1, add the possibility to load kcms directly in the plasmoids config windows. this works only for qml based ones.
> the apply enable and trigger is correctly wired between the config dialog and kcm apis.
> 
> example:
> http://wstaw.org/m/2015/05/07/plasma-desktopvZ1594.png
> 
> 
> Diffs
> -----
> 
>   src/plasma/data/servicetypes/plasma-applet.desktop 476c819 
>   src/plasmaquick/configmodel.h f1b4441 
>   src/plasmaquick/configmodel.cpp ca10f84 
>   src/plasmaquick/configview.cpp 32c5f6e 
> 
> Diff: https://git.reviewboard.kde.org/r/123673/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150507/297fd92d/attachment-0001.html>