Review Request 123626: port libplasma away from sycoca as much as possible
Marco Martin
notmart at gmail.com
Thu May 7 13:15:50 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/
-----------------------------------------------------------
(Updated May 7, 2015, 1:15 p.m.)
Review request for KDE Frameworks and Plasma.
Repository: plasma-framework
Description
-------
this ports most of libplasma away from sycoca, using instead a combination of KPluginLoader and KPackage::PackageLoader instead (so eventually using their own little caches instead of the global sycoca cache)
a kservicetypetrader call is left in the loading of containmentactions since is the only way to make an older workspace still work, but is only a fallback, so containmentactions in plasma-workspace can be ported eventually as well
Diffs (updated)
-----
KF5PlasmaConfig.cmake.in dee79ca
src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43
src/plasma/applet.cpp 2dda381
src/plasma/containment.cpp 7eabbb8
src/plasma/containmentactions.cpp f24bdac
src/plasma/dataengine.cpp 4b3d671
src/plasma/package.cpp 4e0be88
src/plasma/packagestructure.cpp b2686b6
src/plasma/pluginloader.cpp 0ce349a
src/plasma/private/applet_p.cpp 2cbfd06
src/plasma/private/dataenginemanager.cpp b9c5d8e
src/plasma/scripting/appletscript.h 863d707
src/plasma/scripting/dataenginescript.h f7ad3c2
src/plasma/scripting/scriptengine.cpp cc407e7
src/plasma/service.h b5d9b5a
src/plasma/service.cpp 3e9d852
src/plasmapkg/plasmapkg.cpp d606365
src/scriptengines/CMakeLists.txt f566406
src/scriptengines/qml/CMakeLists.txt e7130db
src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d
src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2
src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd
src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45
Diff: https://git.reviewboard.kde.org/r/123626/diff/
Testing
-------
still needs a lot of testing, so far, with a master plasma-workspace notmal workspace functions seems fine
latest version still installs metadata files in kservices5. I would keep this for safety until Plasma 5.4 is released, then try to remove it again
Thanks,
Marco Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150507/bb454dc1/attachment.html>
More information about the Plasma-devel
mailing list