Reverting review 123473

Aleix Pol aleixpol at kde.org
Thu May 7 12:28:04 UTC 2015


On Thu, May 7, 2015 at 1:03 AM, David Edmundson
<david at davidedmundson.co.uk> wrote:
> We had an agreement that there would be no regressions when porting any KCMs
> to QML.
>
> The following regressions remain in the newly ported KCM:
>
>  - combo boxes load in wrong places
> https://codereview.qt-project.org/#/c/111326/ isn't merged, and Qt 5.5 isn't
> a requirement for the Plasma 5.4 release.
>
>  - combo boxes have wrong backgrounds
>
>  - missing automatic accelerators
> (we need a QML version of the class in KXMLGui)
>
> I am happy to help work on those problems, but I am not happy about seeing
> decisions being willfully ignored.
>
> Tomorrow I will be reverting that commit.
>
> David Edmundson
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>

Is it maybe worth discussing to have Qt 5.5 as Plasma 5.4 requirement?

This way, these issues wouldn't get in the way of our work. Also it
helps by making it a reasonable solution to fix Qt rather than
workarounding locally (which we already do too much).

Aleix


More information about the Plasma-devel mailing list