Review Request 123621: Fix reverse scroll setting in Mouse KCM

[Yue Liu]

> On May 4, 2015, 6:40 p.m., Rajeesh K Nambiar wrote:
> > Reverse scrolling works in KF5 based apps (tested with dolphin, konsole etc) and gtk+ apps like firefox here - using synaptics driver. Also see the discussion in bug report https://bugs.kde.org/show_bug.cgi?id=342929 where only KDE4 apps are reported to be affected. Could you share more details?
> 
> Yue Liu wrote:
>     reverse scroll of touchpad and reverse scroll of mouse/trackpoint are different things since kcm_touchpad and kcm_input (mouse) works separately. I don't think synaptics driver support mouse. For that bug report I guess some commenters didn't notice it is for touchpad kcm
> 
> Yue Liu wrote:
>     had a look at kcm_touchpad code and I feel my patch my break touchpad if scroll direction first reverted by xinput then reverted again by synaptics. I don't no how does xinput works together with touchpad driver and I don't have a touchpad for testing.

checked in a laptop with touchpad, if pointer device is using synaptics it won't have "Evdev" properties, only when using evdev driver it will. So this patch won't break touchpad.


- Yue


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123621/#review79861
-----------------------------------------------------------


On May 4, 2015, 9:10 a.m., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123621/
> -----------------------------------------------------------
> 
> (Updated May 4, 2015, 9:10 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> The old swap-button-map method for reverse scroll doesn't work for Qt5, this patch uses XInput2 api to negate "Evdev Scroll Distance" for device with real scroll wheel, and swap "Evdev Wheel Emulation Axes" when device uses emulated scroll wheel, such as Thinkpad Trackpoint.
> 
> 
> Diffs
> -----
> 
>   kcms/input/CMakeLists.txt 6cbe207 
>   kcms/input/mouse.cpp 1450de8 
> 
> Diff: https://git.reviewboard.kde.org/r/123621/diff/
> 
> 
> Testing
> -------
> 
> built on archlinux and tested by replacing kcm_input.so, new kcm works on my machine.
> 
> 
> Thanks,
> 
> Yue Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150507/012cdb1f/attachment.html>