Review Request 123664: Find DBusAddons component explicitly

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123664/#review79995
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On May 6, 2015, 8:50 p.m., Matthias Klumpp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123664/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 8:50 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This apparently causes trouble, since DBusAddons is required by e.g.
> appmenu, and not found in every environment.
> 
> We stumbled upon this in Tanglu, where plasma-workspace failed to build.
> Relevant buildlog excerpts:
> ```
> -- Configuring done
> CMake Warning (dev) at appmenu/CMakeLists.txt:24 (add_library):
>   Policy CMP0028 is not set: Double colon in target name means ALIAS or
>   IMPORTED target.  Run "cmake --help-policy CMP0028" for policy details.
>   Use the cmake_policy command to set the policy and suppress this warning.
> 
>   Target "kded_appmenu" links to target "KF5::DBusAddons" but the target was
>   not found.  Perhaps a find_package() call is missing for an IMPORTED
>   target, or an ALIAS target is missing?
> This warning is for project developers.  Use -Wno-dev to suppress it.
> 
> CMake Warning (dev) at plasma-windowed/CMakeLists.txt:7 (add_executable):
>   Policy CMP0028 is not set: Double colon in target name means ALIAS or
>   IMPORTED target.  Run "cmake --help-policy CMP0028" for policy details.
>   Use the cmake_policy command to set the policy and suppress this warning.
> 
>   Target "plasmawindowed" links to target "KF5::DBusAddons" but the target
>   was not found.  Perhaps a find_package() call is missing for an IMPORTED
>   target, or an ALIAS target is missing?
> This warning is for project developers.  Use -Wno-dev to suppress it.
> 
> CMake Warning (dev) at freespacenotifier/CMakeLists.txt:9 (add_library):
>   Policy CMP0028 is not set: Double colon in target name means ALIAS or
>   IMPORTED target.  Run "cmake --help-policy CMP0028" for policy details.
>   Use the cmake_policy command to set the policy and suppress this warning.
> 
>   Target "kded_freespacenotifier" links to target "KF5::DBusAddons" but the
>   target was not found.  Perhaps a find_package() call is missing for an
>   IMPORTED target, or an ALIAS target is missing?
> This warning is for project developers.  Use -Wno-dev to suppress it.
> [...]
> ```
> ```
> [ 87%] Building CXX object appmenu/CMakeFiles/kded_appmenu.dir/appmenu.cpp.o
> cd appmenu && /usr/bin/c++   -DKCOREADDONS_LIB -DKGUIADDONS_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB -DQT_X11EXTRAS_LIB -DQT_XML_LIB -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -Dkded_appmenu_EXPORTS -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2  -std=c++0x -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -I. -I../../appmenu -I.. -isystem /usr/include/dbusmenu-qt5 -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -isystem /usr/include/x86_64-linux-gnu/qt5/QtX11Extras -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/KF5/KIOCore -isystem /usr/include/KF5 -isystem /usr/include/KF5/KCoreAddons -isystem /usr/include/KF5/KService -isystem /usr/include/KF5/KConfigCore -isystem /usr/include/KF5/KIOWidgets -isystem /usr/include/KF5/KJobWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/KF5/KCompletion -isystem /usr/include/KF5/KWidgetsAddons -isystem /usr/include/KF5/KWindowSystem -isystem /usr/include/KF5/KDELibs4Support -isystem /usr/include/KF5/KDELibs4Support/KDE -isystem /usr/include/x86_64-linux-gnu/qt5/QtPrintSupport -isystem /usr/include/KF5/KCrash -isystem /usr/include/KF5/KConfigWidgets -I/usr/include/KF5/KCodecs -I/usr/include/KF5/KConfigGui -I/usr/include/x86_64-linux-gnu/qt5/QtXml -I/usr/include/KF5/KAuth -isystem /usr/include/KF5/KIOFileWidgets -I/usr/include/KF5/KBookmarks -I/usr/include/KF5/KItemViews -I/usr/include/KF5/KXmlGui -I/usr/include/KF5/Solid -isystem /usr/include/KF5/KI18n -isystem /usr/include/KF5/KNotifications -isystem /usr/include/KF5/KIconThemes -isystem /usr/include/KF5/KGuiAddons -isystem /usr/include/KF5/KUnitConversion -isystem /usr/include/KF5/KTextWidgets -I/usr/include/KF5/SonnetUi -isystem /usr/include/KF5/KParts    -o CMakeFiles/kded_appmenu.dir/appmenu.cpp.o -c ../../appmenu/appmenu.cpp
> In file included from ../../appmenu/appmenu.cpp:26:0:
> ../../appmenu/appmenu.h:29:24: fatal error: kdedmodule.h: No such file or directory
>  #include <kdedmodule.h>
>                         ^
> compilation terminated.
> ```
> See http://buildd.tanglu.org/data/plasma-workspace_4:5.3.0-0tanglu1/build_amd64/198640/plasma-workspace_5.3.0-0tanglu1_amd64.146006.log
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5180bac 
> 
> Diff: https://git.reviewboard.kde.org/r/123664/diff/
> 
> 
> Testing
> -------
> 
> plasma-workspace compiles and works fine.
> 
> 
> Thanks,
> 
> Matthias Klumpp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150506/a3734e4b/attachment-0001.html>