Review Request 123653: New Minimize Windows Plasmoid

[Marco Martin]

> On May 6, 2015, 6 a.m., Martin Gräßlin wrote:
> > From experience with the show desktop feature and the problems when minimizing all windows I highly suggest to only minimize all windows. Don't even try to restore the minimized state when clicked again.
> 
> Sebastian Kügler wrote:
>     That is kind of the point of this feature -- it allows to click twice to "peek" at the desktop.
>     
>     I know that there's a bunch of things that can ruin the state, that's what I'm catching in reset() (from that point on, we can't decide if the feature is active, so we reset its state and it can't unminimize all the windows again. We know that we can't get 100% synthetically clean behaviour (the whole showdesktop discussion), this plasmoid is there to emulate the old behaviour, and that means also unminimize.
> 
> Kai Uwe Broulik wrote:
>     > That is kind of the point of this feature -- it allows to click twice to "peek" at the desktop.
>     
>     Well, that's what show desktop is for?
> 
> Martin Gräßlin wrote:
>     in that case I fail to understand why you go that route. Why not just minimize and be done with it? The way it's currently is bringing back all the bugs from kwin of the last decade in that area without the fixes :-(
> 
> Sebastian Kügler wrote:
>     The show desktop feature hides the panel. This breaks the workflow of people who use the panel to trigger and untrigger the effect. This plasmoid gives the old behaviour (which admittedly has its problems, but it's what many users are used to).
>     
>     Note: you are questioning the very reason to have this plasmoid. We know the feature can't be implemented perfectly, we just have to provide users a way to get the traditional behaviour. If we change this behaviour, this plasmoid becomes moot, and users are still left out in the rain.
> 
> Kai Uwe Broulik wrote:
>     > The show desktop feature hides the panel.
>     
>     About which a lot of people complain. I haven't seen a statement from the UX group why it should hide them, other than "that's what the Dashboard did".
> 
> David Edmundson wrote:
>     so what is the new show desktop for?
> 
> Sebastian Kügler wrote:
>     Yes, I haven't figured out that either.
>     
>     The missing panel during the show  desktop effect removes the way to immediately reverse the action. Users are missing it, and that's understandable since the traditional behaviour of a feature changed. I haven't seen a rationale for hiding the panel either.

new show desktop is used in place of the dashboard, i'll probably rename in the shell "show dashboard" with show desktop, that should make it more clear


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123653/#review79941
-----------------------------------------------------------


On May 6, 2015, 12:16 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123653/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 12:16 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 346837
>     http://bugs.kde.org/show_bug.cgi?id=346837
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> New Minimize Windows Plasmoid
> 
> This plasmoid allows to minimize windows on the current desktop. It does
> not mess with the KWindowSystem::showingDesktop flag, just allows to hide
> and show windows.
> 
> 
> Diffs
> -----
> 
>   applets/CMakeLists.txt 7ada7acad6796bcb18e0f408f00b3720a8df2393 
>   applets/minimizeall/CMakeLists.txt PRE-CREATION 
>   applets/minimizeall/Messages.sh PRE-CREATION 
>   applets/minimizeall/package/contents/config/main.xml PRE-CREATION 
>   applets/minimizeall/package/contents/ui/main.qml PRE-CREATION 
>   applets/minimizeall/package/metadata.desktop PRE-CREATION 
>   applets/minimizeall/plugin/minimizeall.h PRE-CREATION 
>   applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION 
>   applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION 
>   applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION 
>   applets/minimizeall/plugin/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123653/diff/
> 
> 
> Testing
> -------
> 
> Used it for a while.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150506/2e72cf68/attachment-0001.html>