Review Request 123621: Fix reverse scroll setting in Mouse KCM

Yue Liu yue.liu at mail.com
Mon May 4 09:10:14 UTC 2015



> On May 4, 2015, 8:18 a.m., Kai Uwe Broulik wrote:
> > kcms/input/mouse.cpp, line 775
> > <https://git.reviewboard.kde.org/r/123621/diff/1/?file=365674#file365674line775>
> >
> >     QX11Info::display()

didn't know there is xcb until patch is done, also wondering which one is prefered


- Yue


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123621/#review79832
-----------------------------------------------------------


On May 4, 2015, 3:15 a.m., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123621/
> -----------------------------------------------------------
> 
> (Updated May 4, 2015, 3:15 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> The old swap-button-map method for reverse scroll doesn't work for Qt5, this patch uses XInput2 api to negate "Evdev Scroll Distance" for device with real scroll wheel, and swap "Evdev Wheel Emulation Axes" when device uses emulated scroll wheel, such as Thinkpad Trackpoint.
> 
> 
> Diffs
> -----
> 
>   kcms/input/CMakeLists.txt 6cbe207 
>   kcms/input/mouse.cpp 1450de8 
> 
> Diff: https://git.reviewboard.kde.org/r/123621/diff/
> 
> 
> Testing
> -------
> 
> built on archlinux and tested by replacing kcm_input.so, new kcm works on my machine.
> 
> 
> Thanks,
> 
> Yue Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150504/fd58cbcd/attachment.html>


More information about the Plasma-devel mailing list