Review Request 105319: DBus-interface for changing wallpapers

[Andrey Bondrov]

> On Фев. 8, 2013, 9:48 п.п., Albert Astals Cid wrote:
> > Varun, it seems Aaron had some comments, can you have a look at them?
> 
> Varun Herale wrote:
>     Yes, I am looking at it right now.
> 
> Andrey Bondrov wrote:
>     My patch, based on yours and code from kdeplasma-addons/applets/frame/frame.cpp:
>     https://bugs.kde.org/show_bug.cgi?id=217950#c18
>     
>     Also it adds ResizeMethodHint and screenId as options.

I'd like to port it to Plasma 5 but is it possible at all? kdeplasma-addons/applets/frame wasn't ported yet and I don't see any Plasma 5 examples how to work with wallpapers. Almost every line of the patch has to be adjusted to the new API.


- Andrey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/105319/#review27009
-----------------------------------------------------------


On Июль 1, 2012, 5:56 д.п., Varun Herale wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/105319/
> -----------------------------------------------------------
> 
> (Updated Июль 1, 2012, 5:56 д.п.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> This patch is for hosting a dbus-interface that can be used to load any installed wallpaper plugin onto current desktop containment. In case of default "image" plugin, the path to the image can also be sent which will change the wallpaper.  
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
>   plasma/desktop/shell/plasmaapp.h 6ae0c89 
>   plasma/desktop/shell/plasmaapp.cpp 7abd8fc 
> 
> Diff: https://git.reviewboard.kde.org/r/105319/diff/
> 
> 
> Testing
> -------
> 
> Tested on different activities and made sure it works for per-virtual desktop containment.
> 
> Haven't tested on a system with multiple screens though, as I don't have access to one. Could someone please test for that ?
> 
> 
> Thanks,
> 
> Varun Herale
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150331/ae7e652a/attachment.html>