Review Request 122679: Show Desktop feature: refurbished

[Thomas Pfeiffer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review78245
-----------------------------------------------------------


Was adding the usability group more meant as a heads-up to inform us that things are happening on this front, or are you expecting an actual usability review?
In the latter case, we'd need some kind of visualization or at least detailed description of what is happening on the UI side, since we can't read code all that well ;)

- Thomas Pfeiffer


On March 28, 2015, 11:24 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122679/
> -----------------------------------------------------------
> 
> (Updated March 28, 2015, 11:24 p.m.)
> 
> 
> Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin.
> 
> 
> Bugs: 344083
>     https://bugs.kde.org/show_bug.cgi?id=344083
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4                                                                                                                                                                      
> Author: Thomas Lübking                                                                                                   
> Date:   Sun Mar 29 00:15:57 2015 +0100                                                                                                                                                                               
>           
>     Add effect to move windows to corners on showing the desktop                                                                                                                                                     
> commit d92c46e96fe9fb13403b859c5e334b618d45d268                                                                                                                                                                      
> Author: Thomas Lübking                                                                                                   
> Date:   Sun Mar 29 00:15:22 2015 +0100                                                                            
> 
>     Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects                                                                                                                                                                                                             
> commit ed38cf37b26aa15d77c5b73734581055be234233                                                                                                                                                                      
> Author: Thomas Lübking                                                                                                   
> Date:   Sun Mar 29 00:13:41 2015 +0100                                                                                                                                                                               
>             
>     make window elevation scriptable                                                                                                                                                                                 
> commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d                                                                                                                                                                      
> Author: Thomas Lübking                                                                                                   
> Date:   Sun Mar 29 00:12:21 2015 +0100                                                                                                                                                                               
>             
>     forward showingDesktop signal to effects                                                                                                                                                                         
> commit 570a92331f3691c1fb2affa4f853c75d6062f7e3                                                                                                                                                                      
> Author: Thomas Lübking                                                                                                   
> Date:   Sun Mar 29 00:08:32 2015 +0100                                                                            
> 
>     emit signal when showingDesktop changes   
> 
> 
> commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5
> Author: Thomas Lübking
> Date:   Sun Feb 22 16:41:45 2015 +0100
> 
>     add "MinimizeAll" script
>     
>     to compensate withdrawn core feature (which
>     though has been hidden so far)
> 
> commit 983efb916e282d2263b4abcc92f714c06b3bfcc1
> Author: Thomas Lübking
> Date:   Wed Feb 18 02:09:00 2015 +0100
> 
>     break showingDesktop w/ tabbox/PW/DG
>     
> This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop.
> Also, it makes the tabbox more consistent.
> 
> commit ff531c8e2adc407da00bef88f18d03e3829b25fa
> Author: Thomas Lübking
> Date:   Wed Feb 18 01:37:45 2015 +0100
> 
>     implement showingDesktop by raising the desktop window
> 
> commit 190a0cc022d9935d658a6218d0b3caa79b038563
> Author: Thomas Lübking
> Date:   Wed Feb 18 00:09:46 2015 +0100
> 
>     remove secret showDesktopIsMinimizeAll feature
> 
> 
> Diffs
> -----
> 
>   client.h 6b947fe 
>   client.cpp b6af2fa 
>   effects.h ae71d61 
>   effects.cpp 20a8773 
>   effects/CMakeLists.txt 98a9349 
>   effects/badbadwindows/CMakeLists.txt PRE-CREATION 
>   effects/badbadwindows/package/CMakeLists.txt PRE-CREATION 
>   effects/badbadwindows/package/contents/code/main.js PRE-CREATION 
>   effects/badbadwindows/package/metadata.desktop PRE-CREATION 
>   effects/desktopgrid/desktopgrid.cpp 97cb2a3 
>   effects/presentwindows/presentwindows.cpp 7a62ec0 
>   kwin.kcfg 80ca365 
>   layers.cpp ae08207 
>   libkwineffects/kwineffects.h b77e461 
>   manage.cpp 8b1a2ee 
>   options.h 67e5868 
>   options.cpp cdaa851 
>   scripting/scriptedeffect.h 39af241 
>   scripting/scriptedeffect.cpp ba646f6 
>   scripts/CMakeLists.txt 34dedb7 
>   scripts/minimizeall/contents/code/main.js PRE-CREATION 
>   scripts/minimizeall/metadata.desktop PRE-CREATION 
>   tabbox/tabbox.cpp 4a00e4b 
>   workspace.h 16fa351 
>   workspace.cpp f9c1ab1 
> 
> Diff: https://git.reviewboard.kde.org/r/122679/diff/
> 
> 
> Testing
> -------
> 
> * The script (though mostly in KWin4, trouble w/ ksycoca5...)
> * Obviously the supersecret key is now dead ;-)
> * Been playing around with alternate desktop showing.
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150330/44917ddc/attachment.html>