Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

[Hugo Pereira Da Costa]

> On March 30, 2015, 6:06 p.m., Hugo Pereira Da Costa wrote:
> > in principle, ship it. The approach is sound. (indeed KDE4 oxygen and hence breeze moved away from KStyle at some point in the past because it was bringing more issues than solving. Copied the said code from kstyle to these back then. Then with kf5, kstyle got cleaned up *a lot*, so it could be re-used, the duplicated code was thus removed, leaving the hole that you are now filling again)
> > 
> > Thanks ! 
> > 
> > However, please check what's the thing with breezegenericdata in the diff. As is I could not apply the patch (there are some rejs) and this generic data stuff should be quite unrelated. Do you have another patch around ? 
> > 
> > Hugo
> 
> David Edmundson wrote:
>     OK, two things.
>     1) my patch was super old. I have a repo in my kde4 folder and my kde5 source folder, and I didn't git pull. Rebased and reuploading
>     2) I have no idea what that thing about breezegenericdata is about, it's not in my patch. I think it might be RB trying to be clever
> 
> David Edmundson wrote:
>     still shows it, if it's a problem I can just push into a branch.

funny. The patch itself includes:

diff --git a/kstyle/animations/breezegenericdata.cpp b/kstyle/kstylekde4compat.h
similarity index 67%
copy from kstyle/animations/breezegenericdata.cpp
copy to kstyle/kstylekde4compat.h

why would that be ? Is for some reason the file breezegenericdata gone from your local dir ?


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123188/#review78237
-----------------------------------------------------------


On March 30, 2015, 6:22 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123188/
> -----------------------------------------------------------
> 
> (Updated March 30, 2015, 6:22 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> Some important style hints are supplied by the KStyle class, mostly
> importantly whether listviews activate folders on single or double
> click.
> 
> For frameworks this now exists in KStyle, so code was not included in
> Breeze and latest Oxygen. However for KDE4 builds we still need this
> code.
> 
> There is a KDE4 kstyle class, but this behvaiour is very different and
> causes conflicts and a lot of other problems. Re-implementing the part
> we need seems the easier approach
> 
> 
> Diffs
> -----
> 
>   kstyle/CMakeLists.txt e13a13d 
>   kstyle/animations/breezegenericdata.cpp aa7c154 
>   kstyle/breezestyle.h f9df1e8 
>   kstyle/kstylekde4compat.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123188/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150330/9b3e82bb/attachment-0001.html>