Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

David Edmundson david at davidedmundson.co.uk
Mon Mar 30 18:22:45 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123188/
-----------------------------------------------------------

(Updated March 30, 2015, 6:22 p.m.)


Review request for Plasma and Hugo Pereira Da Costa.


Repository: breeze


Description
-------

Some important style hints are supplied by the KStyle class, mostly
importantly whether listviews activate folders on single or double
click.

For frameworks this now exists in KStyle, so code was not included in
Breeze and latest Oxygen. However for KDE4 builds we still need this
code.

There is a KDE4 kstyle class, but this behvaiour is very different and
causes conflicts and a lot of other problems. Re-implementing the part
we need seems the easier approach


Diffs (updated)
-----

  kstyle/CMakeLists.txt e13a13d 
  kstyle/animations/breezegenericdata.cpp aa7c154 
  kstyle/breezestyle.h f9df1e8 
  kstyle/kstylekde4compat.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123188/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150330/e20b285c/attachment.html>


More information about the Plasma-devel mailing list