Review Request 123173: Timer Plasmoid: Add notification on timer completion

[Bernhard Friedreich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123173/
-----------------------------------------------------------

(Updated March 29, 2015, 7:53 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 99c42f6c8f67984abcc270425a1ab2469d199386 by Bernhard Friedreich to branch master.


Repository: kdeplasma-addons


Description
-------

Commit 1: Fixed codingstyle
Commit 2: Fixed warning "Unable to assign int to QEasingCurve"
Commit 3: Added notification on timer completion (not working yet)


Diffs
-----

  applets/timer/package/contents/ui/TimerDigit.qml 94ec17d2c1e6fb02f6d8d3b1c0ea75f16b0fa405 
  applets/timer/package/contents/ui/timer.qml 09df67004f07352436a30195fb13c2550f8ebce7 

Diff: https://git.reviewboard.kde.org/r/123173/diff/


Testing
-------

Event is fired when the timer is finished (console.log output works) but the notification won't show up.

I get this message on console: Are we the only client? (Both have to be true)  false true

How can I send a notification from qml (without c++)? Am I on the right track?

[Edit] Looks like the notification is working if the plasmoid is added somewhere but not from within plasmawindowed.. any ideas?


Thanks,

Bernhard Friedreich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150329/c2629336/attachment.html>