Review Request 123164: Add new Bluetooth applet

[David Rosca]

> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > File Attachment: snapshot4.png - snapshot4.png
> > <https://git.reviewboard.kde.org/r/123164/#fcomment381>
> >
> >     It's "Paired", what would "Connect" do?

It would connect to the device :) That means, connect the HID profile (input devices), A2DP profile (audio), ...


> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > File Attachment: snapshot5.png - snapshot5.png
> > <https://git.reviewboard.kde.org/r/123164/#fcomment382>
> >
> >     I wouldn't show the ID right at a glance. That's super geeky. Hide that in the details section.

Hmm, you are right. But what to show there instead?


> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > src/applet/package/contents/ui/DeviceItem.qml, line 79
> > <https://git.reviewboard.kde.org/r/123164/diff/3/?file=357164#file357164line79>
> >
> >     Property starting with an uppercase letter looks wrong to me, I wonder why that even works.

This is role name from model.


> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > src/applet/package/contents/ui/BluetoothApplet.qml, line 37
> > <https://git.reviewboard.kde.org/r/123164/diff/3/?file=357161#file357161line37>
> >
> >     Would be cool to have the icon reflect the state, ie. use preferences-system-bluetooth-inactive (I think even the Plasma theme has that one)

The icon is already greyed (disabled) when BT is offline. Also preferences-system-bluetooth-inactive is not in breeze icon theme.

Ideally, all icons should be in svg and adjusted for this applet - as in plasma-nm. Right now, the bluetooth icon in tooltip is small because the monochrome version is only in small size (for bluedevil-monolithic).
I'll try to ask vdg :)


> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > src/applet/package/contents/ui/FullRepresentation.qml, line 29
> > <https://git.reviewboard.kde.org/r/123164/diff/3/?file=357165#file357165line29>
> >
> >     Would it be possible to use Plasma's default proxy model?

I don't think so. It sorts devices and also append a (hciX) to device name if there are same devices in multiple adapters.


> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > src/applet/plugin/devicesproxymodel.h, line 38
> > <https://git.reviewboard.kde.org/r/123164/diff/3/?file=357173#file357173line38>
> >
> >     virtual ~DevicesProxyModel() = default; ?

Isn't it the same as if there is no destructor at all?


> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > src/applet/package/contents/ui/ConfigGeneral.qml, lines 29-32
> > <https://git.reviewboard.kde.org/r/123164/diff/3/?file=357163#file357163line29>
> >
> >     Is it really neccessary to be able to turn sections off?

No :D Ok, I will drop the whole config.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78179
-----------------------------------------------------------


On March 29, 2015, 5:18 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> -----------------------------------------------------------
> 
> (Updated March 29, 2015, 5:18 p.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> -------
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the same but for Bluetooth devices.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/config/config.qml PRE-CREATION 
>   src/applet/package/contents/config/main.xml PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc 72257ed 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> -------
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> ----------------
> 
> snapshot4.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150329/bef7a942/attachment-0001.html>