Review Request 123173: Timer Plasmoid: Add notification on timer completion

[Bernhard Friedreich]

> On März 29, 2015, 3:03 nachm., David Edmundson wrote:
> > If it works in plasmashell, ship it.

yeah works in plasmashell :)

I don't have commit access yet - shall I request it? Is this the recommended way? https://identity.kde.org/index.php?r=developerApplication


- Bernhard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123173/#review78176
-----------------------------------------------------------


On März 29, 2015, 2:20 nachm., Bernhard Friedreich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123173/
> -----------------------------------------------------------
> 
> (Updated März 29, 2015, 2:20 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Commit 1: Fixed codingstyle
> Commit 2: Fixed warning "Unable to assign int to QEasingCurve"
> Commit 3: Added notification on timer completion (not working yet)
> 
> 
> Diffs
> -----
> 
>   applets/timer/package/contents/ui/TimerDigit.qml 94ec17d2c1e6fb02f6d8d3b1c0ea75f16b0fa405 
>   applets/timer/package/contents/ui/timer.qml 09df67004f07352436a30195fb13c2550f8ebce7 
> 
> Diff: https://git.reviewboard.kde.org/r/123173/diff/
> 
> 
> Testing
> -------
> 
> Event is fired when the timer is finished (console.log output works) but the notification won't show up.
> 
> I get this message on console: Are we the only client? (Both have to be true)  false true
> 
> How can I send a notification from qml (without c++)? Am I on the right track?
> 
> [Edit] Looks like the notification is working if the plasmoid is added somewhere but not from within plasmawindowed.. any ideas?
> 
> 
> Thanks,
> 
> Bernhard Friedreich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150329/33cbbf8c/attachment.html>