Review Request 123161: Add copy and paste support for calculator widget
David Edmundson
david at davidedmundson.co.uk
Sat Mar 28 15:15:53 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123161/#review78150
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On March 28, 2015, 2:45 p.m., Bernhard Friedreich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123161/
> -----------------------------------------------------------
>
> (Updated March 28, 2015, 2:45 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 318221
> http://bugs.kde.org/show_bug.cgi?id=318221
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> The current displayed value from the textfield can be copied.
> Content from the clipboard can be pasted but only if the content
> is a valid number
>
> BUG: 318221
>
>
> Diffs
> -----
>
> applets/calculator/package/contents/ui/calculator.qml 23f74bd1ac7de6b7f4519677bd96aa351a91cff1
>
> Diff: https://git.reviewboard.kde.org/r/123161/diff/
>
>
> Testing
> -------
>
> Copying:
> *) Tried copying entered numbers and results - works for me :)
>
> Pasting:
> *) Pasting "asdf" leads to nothing being pasted - correct
> *) Pasting "5" appends the number to the currently entered input or replaces the current number in case an operator has been pressed before
>
> Only pasting doubles is possible - no signs or full math expressions are supported.
> It looks like the plasmoid doesn't supports signed numbers in general (e.g. 5 - -5 doesnt result in 10)
>
> Comments welcome :) This is my second patch so hopefully my work isn't complete garbage :P
>
>
> Thanks,
>
> Bernhard Friedreich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150328/32395625/attachment.html>
More information about the Plasma-devel
mailing list