Review Request 123161: Add copy and paste support for calculator widget

Bernhard Friedreich friesoft at gmail.com
Fri Mar 27 23:21:13 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123161/
-----------------------------------------------------------

Review request for Plasma.


Bugs: 318221
    http://bugs.kde.org/show_bug.cgi?id=318221


Repository: kdeplasma-addons


Description
-------

The current displayed value from the textfield can be copied.
Content from the clipboard can be pasted but only if the content
is a valid number

BUG: 318221


Diffs
-----

  applets/calculator/package/contents/ui/calculator.qml 23f74bd1ac7de6b7f4519677bd96aa351a91cff1 

Diff: https://git.reviewboard.kde.org/r/123161/diff/


Testing
-------

Copying:
*) Tried copying entered numbers and results - works for me :)

Pasting:
*) Pasting "asdf" leads to nothing being pasted - correct
*) Pasting "5" pasts 5 - replaces the currently entered text with the pasted content (this could be worked around - should it append?)
*) Pasting "= 5 + 3" passes through validation - no idea why yet - this should be possible I guess?

Comments welcome :) This is my second patch so hopefully my work isn't complete garbage :P


Thanks,

Bernhard Friedreich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150327/705c65b1/attachment.html>


More information about the Plasma-devel mailing list