Review Request 123142: Fixes plasma-desktop compilation with boost 1.57

Tomaz Canabrava tcanabrava at kde.org
Fri Mar 27 15:20:55 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123142/
-----------------------------------------------------------

(Updated March 27, 2015, 3:20 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Repository: plasma-desktop


Description
-------

Plasma-desktop uses Boost::optional on a few places, but it stored the value as boolean ( bool thisValid  = currentValue; for instance ), the issue is that boost::optional conversion to bool must be explicit, thus a static_cast is needed.


Diffs
-----

  lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp 664b399 

Diff: https://git.reviewboard.kde.org/r/123142/diff/


Testing
-------

compiles.


Thanks,

Tomaz  Canabrava

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150327/c6cc99d0/attachment.html>


More information about the Plasma-devel mailing list