Review Request 123142: Fixes plasma-desktop compilation with boost 1.57
David Edmundson
david at davidedmundson.co.uk
Fri Mar 27 14:20:43 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123142/#review78121
-----------------------------------------------------------
is this redundant now?
- David Edmundson
On March 26, 2015, 7:47 p.m., Tomaz Canabrava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123142/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 7:47 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Plasma-desktop uses Boost::optional on a few places, but it stored the value as boolean ( bool thisValid = currentValue; for instance ), the issue is that boost::optional conversion to bool must be explicit, thus a static_cast is needed.
>
>
> Diffs
> -----
>
> lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp 664b399
>
> Diff: https://git.reviewboard.kde.org/r/123142/diff/
>
>
> Testing
> -------
>
> compiles.
>
>
> Thanks,
>
> Tomaz Canabrava
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150327/63ed65d4/attachment.html>
More information about the Plasma-devel
mailing list