Review Request 123136: Fix one pixel gap between screenedge and right placed vertical panel

Bhushan Shah bhush94 at gmail.com
Fri Mar 27 12:22:03 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123136/
-----------------------------------------------------------

(Updated March 27, 2015, 12:22 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Martin Gräßlin and Marco Martin.


Changes
-------

Submitted with commit 975e5009c176eb378daa5c8f74cd4cffb64ff459 by Bhushan Shah to branch master.


Bugs: 339323 and 340549
    https://bugs.kde.org/show_bug.cgi?id=339323
    https://bugs.kde.org/show_bug.cgi?id=340549


Repository: plasma-workspace


Description
-------

Appearantly right() / bottomRight() / topRight() returns values with 1
pixel x off for historical reasons and hence 1px gap. This causes the
autohide panel not hiding automatically.


Diffs
-----

  shell/panelview.cpp 3435736 

Diff: https://git.reviewboard.kde.org/r/123136/diff/


Testing
-------

added right aligned panel and tested various combinations


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150327/8bfd3c62/attachment.html>


More information about the Plasma-devel mailing list