Review Request 122859: WIP: Don't animate from previous pixmap when IconItem has been invisible

[Eike Hein]

> On March 14, 2015, 10:29 p.m., Eike Hein wrote:
> > > @Eike: Could you check whether this makes it more viable for Kicker?
> > 
> > Will do tomorrow. Might make it _more_ viable, but probably not viable yet - the other problem is that Kicker really wants to disable the blend tween completely, because it works very hard to reuse existing delegate instances when you switch categories. That is, when you move from one category to another and they differ in size, delegates may be created or destroyed as needed to fit the new size, but existing ones are reused and just handed new data. Since the text labels don't blend it's awkward when the icons do, and also generally makes things feel too slow.
> 
> Eike Hein wrote:
>     Tried it now - initial appearance seems fine, but the crossblends during category moves are still the expected problem (they don't even start at the same time, so ... really ugly).

Nope, doesn't help with bug 345545.


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122859/#review77482
-----------------------------------------------------------


On March 14, 2015, 2:53 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122859/
> -----------------------------------------------------------
> 
> (Updated March 14, 2015, 2:53 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> We have a lot of reusable singletons that are just hidden when unneeded (tooltip, osd). IconItem, however, will always fade from the previous state, even if the previous action happened minutes ago.
> 
> This patch makes it track its visibility and skip the fade-and-wait dance when it just became visible. It also removes a visible false call in the tooltip which I didn't know what it was for. (With it in place, the IconItem always becomes visible when moving between tooltip areas, breaking the animation altogether).
> 
> @Eike: Could you check whether this makes it more viable for Kicker?
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp d653bf3 
>   src/declarativeimports/core/tooltip.cpp 40e0af5 
> 
> Diff: https://git.reviewboard.kde.org/r/122859/diff/
> 
> 
> Testing
> -------
> 
> Moving between tray icons - icon fades, moving reaaaally rapidly causes it not to load any icon until you halt (dunno if that happened before but doesn't seem too bad)
> Hovering tray icon, leaving, waiting, hovering another one - icon does not fade, is there right away
> 
> There is an issue with the OSD where it would not fade at all anymore when changing states (eg. change volume, then screen brightness), only on the first invocation, hence the "WIP" badge.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150326/a2db412d/attachment-0001.html>