Review Request 123136: Fix one pixel gap between screenedge and right placed vertical panel

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123136/#review78069
-----------------------------------------------------------



shell/panelview.cpp (line 429)
<https://git.reviewboard.kde.org/r/123136/#comment53490>

    and here?



shell/panelview.cpp (line 433)
<https://git.reviewboard.kde.org/r/123136/#comment53491>

    and here.



shell/panelview.cpp (line 443)
<https://git.reviewboard.kde.org/r/123136/#comment53489>

    and here?



shell/panelview.cpp (line 453)
<https://git.reviewboard.kde.org/r/123136/#comment53488>

    comments
    
    Otherwise someone is going to "smartly" change this to say topLeft();


- David Edmundson


On March 26, 2015, 4:41 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123136/
> -----------------------------------------------------------
> 
> (Updated March 26, 2015, 4:41 p.m.)
> 
> 
> Review request for Plasma, Martin Gräßlin and Marco Martin.
> 
> 
> Bugs: 339323 and 340549
>     https://bugs.kde.org/show_bug.cgi?id=339323
>     https://bugs.kde.org/show_bug.cgi?id=340549
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Appearantly right() / bottomRight() / topRight() returns values with 1
> pixel x off for historical reasons and hence 1px gap. This causes the
> autohide panel not hiding automatically.
> 
> 
> Diffs
> -----
> 
>   shell/panelview.cpp 3435736 
> 
> Diff: https://git.reviewboard.kde.org/r/123136/diff/
> 
> 
> Testing
> -------
> 
> added right aligned panel and tested various combinations
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150326/fc665c35/attachment.html>