Review Request 123131: Port kio_man away from kdelibs4support

Lukáš Tinkl lukas at kde.org
Wed Mar 25 21:54:08 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123131/#review78048
-----------------------------------------------------------



man/kio_man.cpp (line 242)
<https://git.reviewboard.kde.org/r/123131/#comment53475>

    Not correct, this returns only user configured list of languages, whereas it previously returned the full list.


- Lukáš Tinkl


On Bře. 25, 2015, 10:17 odp., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123131/
> -----------------------------------------------------------
> 
> (Updated Bře. 25, 2015, 10:17 odp.)
> 
> 
> Review request for KDE Frameworks, Plasma and Martin Koller.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Port kio_man away from kdelibs4support
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 02ae89f2524324f758450ad368f64849e39b2f7d 
>   man/CMakeLists.txt cb4585a289d3f69b8a16429ce87bfce115d1cc27 
>   man/kio_man.cpp e8cf2d70c50c4c20adbb5a81a6213175d397b76e 
>   man/kmanpart.cpp 3af7fc182806e8b89297e8de884ce611c827e881 
>   man/man2html.cpp 3c493ba334bce890b450d7b11ab00c6e783708d4 
> 
> Diff: https://git.reviewboard.kde.org/r/123131/diff/
> 
> 
> Testing
> -------
> 
> man view in kdevelop5 works
> 
> Not sure about the `KLocale::global()->languageList();` -> `QLocale().uiLanguages();` change though so I would like some feedback.
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150325/bc85faee/attachment-0001.html>


More information about the Plasma-devel mailing list