Review Request 122850: Fix regression in highlight of tabboxes

Albert Astals Cid aacid at kde.org
Wed Mar 25 20:18:04 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122850/
-----------------------------------------------------------

(Updated mar. 25, 2015, 8:18 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Bugs: 341007
    http://bugs.kde.org/show_bug.cgi?id=341007


Repository: kdeplasma-addons


Description
-------

Don't animate the highlight when the holder is not visible

This way it's always at the correct place on first show.


Diffs
-----

  windowswitchers/thumbnails/contents/ui/main.qml f70b3fc 
  windowswitchers/informative/contents/ui/main.qml e50dee6 
  windowswitchers/text/contents/ui/main.qml 79f97c9 
  windowswitchers/compact/contents/ui/main.qml c90959d 
  windowswitchers/IconTabBox.qml 589d3da 

Diff: https://git.reviewboard.kde.org/r/122850/diff/


Testing
-------

Did an alt+tab, didn't get dizzy because the tab was going backwards when it should not.


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150325/8e820359/attachment.html>


More information about the Plasma-devel mailing list