Review Request 123046: Use own copy of org.kde.JobView.xml
David Rosca
nowrep at gmail.com
Wed Mar 25 18:36:35 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123046/#review78040
-----------------------------------------------------------
Ping. This is now needed with kjobwidgets master for setError being called in adaptors and thus making the "error" value available in dataengine.
- David Rosca
On March 19, 2015, 11:16 a.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123046/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 11:16 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Use own copy of org.kde.JobView interface file to make it possible to extend the interface without breaking build (https://git.reviewboard.kde.org/r/122970/)
>
> This also fixes 2 cases where error/errorText would be incorrect in applicationsjob dataengine.
>
>
> Diffs
> -----
>
> dataengines/applicationjobs/CMakeLists.txt e25ff0c
> dataengines/applicationjobs/jobaction.cpp f06977e
> kuiserver/CMakeLists.txt a4fc049
> kuiserver/org.kde.JobView.xml PRE-CREATION
> kuiserver/progresslistmodel.cpp 11fccac
>
> Diff: https://git.reviewboard.kde.org/r/123046/diff/
>
>
> Testing
> -------
>
> build & works fine
>
>
> Thanks,
>
> David Rosca
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150325/5d0a5c8e/attachment-0001.html>
More information about the Plasma-devel
mailing list