Review Request 123124: Display an instance of the grey login strip in the sddm theme on every screen

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123124/#review78036
-----------------------------------------------------------

Ship it!


Looks good. Do you have commit access?


lookandfeel/contents/loginmanager/Main.qml (line 62)
<https://git.reviewboard.kde.org/r/123124/#comment53474>

    would be nice if you could also add a fake screenModel inisde the dummydata folder so the test still work?


- David Edmundson


On March 24, 2015, 11:29 p.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123124/
> -----------------------------------------------------------
> 
> (Updated March 24, 2015, 11:29 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Display the grey login strip in sddm on every screen separated instead
> of displaying one strip that goes over all screens.
> The latter could result in a password promt or user selection that is
> subdivided into two parts on two screens.
> This commit displays the strip on every screen (like the background
> image) so it won't be subdivided anymore.
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/loginmanager/Main.qml edabd0c6eac1fbc038208010cc6c772acc735105 
> 
> Diff: https://git.reviewboard.kde.org/r/123124/diff/
> 
> 
> Testing
> -------
> 
> Using sddm and the breeze theme with one and two monitors attached.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150325/a8489bfe/attachment.html>