Review Request 123119: Add a component file that mimicks KTitleWidget

Marco Martin notmart at gmail.com
Tue Mar 24 18:13:21 UTC 2015



> On March 24, 2015, 5:59 p.m., Marco Martin wrote:
> > I wonder if we want instead push for the heading api in apps too (i guess would be another header component in this import here)
> 
> Marco Martin wrote:
>     both api and look i mean
> 
> David Edmundson wrote:
>     Would be fine with me.
>     
>     So copy the plasmaextras ones and make it use the system font?
> 
> Marco Martin wrote:
>     I'm fine both with that and this version.
>     may be a question for the VDG?

question would be icon yes/no and if the typography-based approach to titles with a "level" that changes font size and "importance" makes sense there


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123119/#review78014
-----------------------------------------------------------


On March 24, 2015, 3:25 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123119/
> -----------------------------------------------------------
> 
> (Updated March 24, 2015, 3:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This will stick to the app's QtQuickControls theme.
> 
> This is needed as otherwise people put PlasmaHeadings in apps which
> otherwise follow the QStyle which is going to look really inconsistent.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrols/Title.qml PRE-CREATION 
>   tests/titletest.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123119/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150324/68c5814f/attachment-0001.html>


More information about the Plasma-devel mailing list