Review Request 122939: Immediately hide tooltip on ToolTipArea destruction or when it becomes empty

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122939/
-----------------------------------------------------------

(Updated März 23, 2015, 7:06 nachm.)


Review request for Plasma.


Changes
-------

Keep track who has opened the dialog last and only let that one hide the dialog on destruction/text change


Repository: plasma-framework


Description
-------

When the tooltip is empty (no text and no subtext and no mainitem) it will not show. However, when it becomes empty while it is shown, it stays there as a small rectangle.

This patch hides the tooltip immediately (so KWin's fadeout animation still has the proper content rather than the empty tooltip) when the area has been destroyed or its content becomes empty.

It access s_dialog directly not to unneccessarily create a tooltipInstance just for a call in the destructor or that wouldn't have effect without a tooltip anyway.


Diffs (updated)
-----

  src/declarativeimports/core/tooltip.h 7a58826 
  src/declarativeimports/core/tooltip.cpp 40e0af5 
  src/declarativeimports/core/tooltipdialog.h d81dadb 
  src/declarativeimports/core/tooltipdialog.cpp 6c5675e 

Diff: https://git.reviewboard.kde.org/r/122939/diff/


Testing
-------

Hovered KMail tray icon, closed KMail using Ctrl+Q while still hovering the icon.
Previously the tooltip would change into an empty rectangle, staying there until the tooltip times out, now it hides nicely.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150323/68a735b1/attachment-0001.html>